Open Cryptophobia opened 6 years ago
From @slack on May 14, 2016 23:36
If the value is found, it should unset that value, if the value doesn't match it should throw a bad request. If no value is given it should clear the value, like it does now.
From @Joshua-Anderson on May 14, 2016 23:49
At the moment there is no validation on the process given, so the cli is trying to unset limits on the process web=64M
, which doesn't exist.
Just to clarify, you would expect:
deis limits:unset web=64M
to return an error like Error: No limits defined for process 'web=64M'
or do you expect it to unset the memory limit on process web
From @slack on May 15, 2016 0:48
I would expect deis limits:unset web=64M
to clear the limit if it matched the currently set value of '64M', otherwise throw an error and not create a new release.
If deis limits:unset web=64M
does match, then unset and create the release.
If deis limits:unset web
is called it should unset the memory limit for web, regardless of its current value.
From @bacongobbler on May 19, 2016 17:56
given that we have a workaround, is this something we can get back to after 2.0?
From @vdice on May 24, 2016 1:34
ping @slack as to if this issue needs to be resolved in v2.0-rc1
-- if so, let's label with showstopper
-- otherwise, as @bacongobbler mentioned, I might suggest we move to a later milestone...
From @slack on May 14, 2016 23:25
Looks like
deis limits:unset web
does, bit of a surprise behavior.Copied from original issue: deis/workflow-cli#62