search

teamhephy / workflow-cli

MIT License
2 stars 13 forks source link

feat(workflow-cli): support timeouts command in CLI #32

Closed notmaxx closed 6 years ago

notmaxx commented 6 years ago

ok, will do

On Wed, Sep 12, 2018 at 11:27 AM anton notifications@github.com wrote:

@Cryptophobia requested changes on this pull request.

Need to change the imports from github.com/deis/pkg/... and github.com/deis/controller-sdk-go/... to github.com/teamhephy/...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/teamhephy/workflow-cli/pull/32#pullrequestreview-154784426, or mute the thread https://github.com/notifications/unsubscribe-auth/ARuq8mSOEiQof2CrYLc6lz5-kVEmB6biks5uaVIfgaJpZM4Usu7q .

--

ap

notmaxx commented 6 years ago

hi @Cryptophobia i made the changes but seems master of workflow-cli contains a lot of github.com/deis... imports. Are we going to fix in master branch so I could merge it into mine?

Cryptophobia commented 6 years ago

@notmaxx After we merge https://github.com/teamhephy/workflow-cli/pull/36 you should be able to merge master into your branch and resolve the above.

Cryptophobia commented 6 years ago

@notmaxx , thank you for the contribution and thanks for fixing glide dependencies!

LGTM, let's merge it in! :rocket: :man_astronaut: