search

teamhephy / workflow-cli

MIT License
2 stars 13 forks source link

feat(workflow-cli): support command services in CLI #33

Closed notmaxx closed 6 years ago

notmaxx commented 6 years ago

Implementation and tests for Service functionality

Cryptophobia commented 6 years ago

github.com/deis/pkg/ has been moved to github.com/teamhephy/pkg/ via https://github.com/teamhephy/pkg/pull/1

kingdonb commented 6 years ago

Thanks @notmaxx

notmaxx commented 6 years ago

@kingdonb we need to merge first controller-sdk-go because it has new API otherwise workflow-cli build will get broken - see https://github.com/teamhephy/controller-sdk-go/pull/2

Cryptophobia commented 6 years ago

@kingdonb we need to merge first controller-sdk-go because it has new API otherwise workflow-cli build will get broken - see teamhephy/controller-sdk-go#2

Everything in controller-sdk-go has been moved correctly to teamhephy org with this PR merged earlier today: https://github.com/teamhephy/controller-sdk-go/pull/4

notmaxx commented 6 years ago

@Cryptophobia @kingdonb i think i need to fix controller-sdk-go changes - there are still references to deis namespace, should I?

Cryptophobia commented 6 years ago

@Cryptophobia @kingdonb i think i need to fix controller-sdk-go changes - there are still references to deis namespace, should I?

Yes, package locations need to change from github.com/deis/... to github.com/teamhephy/... in https://github.com/teamhephy/controller-sdk-go/pull/2 as well.

Cryptophobia commented 6 years ago

@notmaxx Can you resolve merge conflict due to merging timeouts before this?

notmaxx commented 6 years ago

@Cryptophobia done

notmaxx commented 6 years ago

@kingdonb done