fix(charts): fix in-cluster test setup via helm chart

rwos commented 5 years ago

removed the helm repo add from the README because I think this chart isn't actually hosted anywhere currently(?)
and then, there's some hackery in the actual pod spec, which should mean that you only need to deploy this into the same namespace as hephy and it'll just work™️, no matter how the external DNS is set up (or whether it's set up at all). However, this probably only works with deis-router, not with the experimental native ingress.

kingdonb commented 5 years ago

Thanks for doing this... I haven't tried or looked at the e2e in ingress mode, like you say, or thought about this at all. If there's really no e2e for ingress mode, that's surely something else we'll have to tackle before we can say that it's not "Experimental" anymore.

Would seem to make sense for us to have e2e tests for each supported ingress controller. There is a proposal in the next release to build in configuration for ingress class annotations, adding on some detection of what is installed and available on the cluster, and some smart automation around that.

I haven't looked at e2e tests in quite a while. We should probably have them hosted in a repo really, somewhere, to replace the old deis one that you removed. I'm looking at ChartMuseum again now, I hear v0.8.0 supports API token authentication, I wonder how that works with Helm!

Maybe I will host another chart repo for this. It's on my bucket list. Good that you've found a way to make the documentation show how it can be made to work at least in the mean time, without it. Thx

Cryptophobia commented 5 years ago

@rwos, does it make sense to build a container for workflow-e2e and host it in chart.teamhephy.com. Would that be more in line with the original intention?

Cryptophobia commented 5 years ago

@rwos , can you also rebase from master? I am going to merge this fix https://github.com/teamhephy/workflow-e2e/pull/20 to the charts so we can fix the third option and pull the chart from charts.teamhephy.com

rwos commented 5 years ago

@Cryptophobia as for hosting the chart - yeah, I guess that would be nice. Though just using a checked-out version also works, so - whatever 😄

rwos commented 5 years ago

@Cryptophobia I rebased this onto the current master

Cryptophobia commented 5 years ago

Alright, I also uploaded the current chart that can be pulled from charts.teamhephy.com:

hephy/workflow-e2e   v2.20.0     End-to-end tests for Deis Workflow, executed in...

teamhephy / workflow-e2e

fix(charts): fix in-cluster test setup via helm chart #19