search

teamhide / fastapi-boilerplate

FastAPI boilerplate for real world production
986 stars 156 forks source link

Benchmarking strategy is wrong here.... #23

Closed ManiMozaffar closed 6 months ago

ManiMozaffar commented 1 year ago

Hey,

I just noticed that you didn't use same driver when benchmarking these ORMs, so it gave tortoise a not deserved boost! I believe you should have used all with psycopg2, since all support it as far as I know. Or maybe perform a sync and async benchmark driver, then compare them. Those who supports async driver usually supports asyncpg, since it's best out there.

teamhide commented 6 months ago

I replaced PostgreSQL to MySQL. Please check latest codes.