search

teaminkling / now-playing

A macOS application for Spotify notifications and a now playing visual widget!
MIT License
80 stars 5 forks source link

Rewrite in TypeScript #14

Open paced opened 3 years ago

paced commented 3 years ago

Please explain the problem/why you would want to see a change and any workarounds you might have in place.

I don't want to maintain a JavaScript application when TypeScript exists. I'm going to prioritise a change to using TypeScript instead of JavaScript alongside Electron.

This should be good for contributors as well.

On another note, if I'm going to maintain this application, I need a thorough understanding of how the old app works. This will allow me to have that familiarity.

paced commented 3 years ago

Working on this currently. Will be part of the v0.8.0 release. This requires a pretty big rewrite:

paced commented 3 years ago

I need to be more careful: perhaps leave the renderer JS file as JavaScript and change everything else?

paced commented 3 years ago

I could rewrite much of the code as using the custom protocol and handling those signals.

paced commented 3 years ago

Moving refactoring tickets to v0.12.0.

paced commented 2 years ago

This is going well so far: entire main thread code has been rewritten in TypeScript along with a few other tickets I was working on at the same time.

This dramatically reduces the amount of code and I think it makes it much easier to read and contribute to as well. It should be a good change provided I can convince people to update to v0.11.0.