Notifications Do Not Work On Monterey

teaminkling / now-playing

A macOS application for Spotify notifications and a now playing visual widget!

MIT License

80 stars 5 forks source link

Notifications Do Not Work On Monterey #68

Closed jamesf-hub closed 3 years ago

jamesf-hub commented 3 years ago

Describe your problem. Please include at least reproduction steps, expected output, and environment.

Install app. Player works but no notification prompts.

Environment: macOS 12 (21A5506j)

paced commented 3 years ago

Thank you for the report @applekillerbyjames.

I'll need some time to investigate this bug since I'm still on Big Sur. I expect the next Apple keynote is in 5 days and I can upgrade when that's generally available.

Before then: did it work before you updated to macOS 12? What version of Now Playing are you using? Have you given "Spotify" notification permissions? Should look like this:

jamesf-hub commented 3 years ago

I am not getting the notification permission prompt.

jamesf-hub commented 3 years ago

Thank you for the report @applekillerbyjames.

I'll need some time to investigate this bug since I'm still on Big Sur. I expect the next Apple keynote is in 5 days and I can upgrade when that's generally available.

Before then: did it work before you updated to macOS 12? What version of Now Playing are you using? Have you given "Spotify" notification permissions? Should look like this:

I have also not used Now Playing before Monterey.

paced commented 3 years ago

Okay, I am currently investigating this problem. It's either a bug in the notifier or a bug in the permissions, so either way I'll release a patch version for this when I can.

paced commented 3 years ago

Whoops, I set it to closed a bit too early. Version v0.9.1 is being drafted. I will link it once it's finished.

paced commented 3 years ago

v0.9.1 has been released! Please let me know if this solves your issue.

jamesf-hub commented 3 years ago

YESSSSS!!! thank you

jamesf-hub commented 3 years ago

if I may what exactly was the issue?

paced commented 3 years ago

@applekillerbyjames No problem!

In short, the issue was that we were running a very old version of our notifications library node-notifier, v5.3.0. I bumped up the version to v10.0.0 which should include support for the notifications API on beta versions of macOS.

A lot of our modernisation process from the previous maintainer was to update very old libraries and get the whole thing more secure. With node-notifier updated, I can say we're safely entirely in 2021 now.

jamesf-hub commented 3 years ago

additionally, the play/pause shuffle doesn't work either.

paced commented 3 years ago

Seems to work on my machine.

Sometimes that happens on first load, if restarting both Now Playing and Spotify doesn't work, please raise another issue and I'll look into it.

Either way I do know it sometimes happens so I'll make sure it's more stable over future versions to eliminate this problem.