search

teaminkling / now-playing

A macOS application for Spotify notifications and a now playing visual widget!
MIT License
80 stars 5 forks source link

Use a Spotify SDK rather than our messy calls #77

Open paced opened 3 years ago

paced commented 3 years ago

It is better to use somebody's tested work rather than writing our own code to interact with the Spotify SDK. It would clean up a lot of the code for contributors.

This should be done before the TSX refactor.

alexresiga commented 3 years ago

Hi! I have previously used this https://github.com/jmperez/spotify-web-api-js which works really great. I have previously worked with spotify web api for a few projects and I could give a helping hand with this one

paced commented 3 years ago

Apologies for the late reply, wasn't really available this weekend @alexresiga.

Sure, that sounds good. That particular SDK works perfectly for us, feel free to go ahead! Feel free to keep me in the loop or ask questions about the existing codebase if needed. Thanks!

paced commented 3 years ago

Hi @alexresiga, @teaminkling/engineering's sprint is mostly focused on other internal projects but I'll have some time to move back to Now Playing soon. I'll likely make sweeping changes to much of the codebase. Would you like some more time to work on this before I make those changes?

alexresiga commented 3 years ago

Hi @paced, unfortunately I got caught up with a lot of stuff at my job and I didn't even manage to get started. You can go on with your changes and I'll see when I will have the time to work on it.

paced commented 3 years ago

Cheers @alexresiga!

Sure, I estimate I'll be able to look at this again on Sunday or some time thereafter.