search

teamneoneko / Cats-Blender-Plugin-Unofficial-

A tool designed to shorten steps needed to import and optimize models into VRChat. Compatible models are: MMD, XNALara, Mixamo, DAZ/Poser, Blender Rigify, Sims 2, Motion Builder, 3DS Max and potentially more, originally by absolute-quantum. Not Official.
GNU General Public License v3.0
360 stars 13 forks source link

Custom Model Creation: If armature To Merge is a child of the Base armature, CATS reports an error #174

Closed DrSakuu closed 3 weeks ago

DrSakuu commented 4 weeks ago

I have a collar armature parented to the neck bone of the base armature, but now I want to merge the two armatures. When I try to use Merge Armatures in Custom Model Creation, CATS wants me to use the "Fix Model" feature, which should never be recommended. The solution is to clear the parent relation first and then merge, but the tool should do that automatically.

Blender Version: 4.2.1 Cats Version: 4.2.1.2 OS: Windows 11

Steps to re-produce:

  1. Parent an armature to the base armature you're trying to merge to.
  2. Try to use Merge Armatures to attach it to a bone on the base armature and then CATS wants you to use the "Fix Model" feature.
  3. Unparent the armature To Merge and then Merge Armatures works without errors.

20240902_142345-DLJ3-blender 20240902_140200-wLwQ-blender

Yusarina commented 4 weeks ago

Hello,

From my understanding (and I will need to review the code to confirm), this message should only appear if a non-standard armature is detected. This suggests that your armature isn't standard, or CATS doesn't recognize it as such.

I will investigate this issue further and consider changing the warning to something like:

"Non-standard armature detected. If this is an MMD/VRM model or a model not set up for Unity, please consider using the 'Fix MMD Model' function. If not, press OK to continue with the merge."

This approach would allow users to proceed if they press OK instead instead of just cancelling the merge.

DrSakuu commented 2 weeks ago

I only tested this just now, but I get the error AttributeError: module 'bl-ext.user-default.cats_blender_plugin.tools.common' has no attribute 'show_warning' on Cats version 4.2.1.3 20240913_175102-v3yO-blender