teamniteo / salarycalc

Elm engine running the Niteo Salary Calculator
https://niteo.co/salary-calculator
MIT License
4 stars 2 forks source link

Fix #14: CI fails to publish #15

Closed tad-lispy closed 5 years ago

tad-lispy commented 5 years ago

As discussed in the issue https://github.com/niteoweb/salarycalc/issues/14#issuecomment-476502503 I'm not really sure why the problem happens, but this seems to fix it. Let me know if you want to dig deeper.

codecov[bot] commented 5 years ago

Codecov Report

Merging #15 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #15     +/-   ##
===========================================
  Coverage     33.83%   33.83%             
- Complexity        0     5338   +5338     
===========================================
  Files             1        1             
  Lines           594      594             
===========================================
  Hits            201      201             
  Misses          393      393

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 49ee03e...6ed3640. Read the comment docs.

zupo commented 5 years ago

Purging the cache is not ideal, but it only happens on master merge builds that usually don't need to be repeated. The majority of builds are PR builds.