teamniteo / salarycalc

Elm engine running the Niteo Salary Calculator
https://niteo.co/salary-calculator
MIT License
4 stars 2 forks source link

Salarycalc 2.0 #44

Closed zupo closed 4 years ago

zupo commented 4 years ago

Ref: https://github.com/niteoweb/operations/issues/1220

codecov[bot] commented 4 years ago

Codecov Report

Merging #44 into master will decrease coverage by 0.23%. The diff coverage is 55.93%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #44      +/-   ##
============================================
- Coverage     41.86%   41.63%   -0.24%     
- Complexity     1904     1907       +3     
============================================
  Files             3        3              
  Lines           535      538       +3     
============================================
  Hits            224      224              
- Misses          311      314       +3
Impacted Files Coverage Δ Complexity Δ
src/Config.elm 100% <100%> (ø) 68 <9> (ø) :arrow_down:
src/Salary.elm 100% <100%> (ø) 7 <2> (ø) :arrow_down:
src/Main.elm 35.91% <49.01%> (-0.23%) 1832 <233> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2d443b...465ca26. Read the comment docs.

zupo commented 4 years ago

Went through latest changes with @dmurko, rebased tiny commits into one: https://github.com/niteoweb/salarycalc/pull/44/commits/21db984bf65fd47854a5df611256f75e2bf4f64f

zupo commented 4 years ago
  1. Sync changes of role names.
  2. The base salaries look off on the first look, against what do I compare them?
  1. done
  2. You can't, because base salaries are now US averages, no longer discounted by affordability ratio (only location factors are discounted, which is correct).
dmurko commented 4 years ago

Can we make countries alphabetical?

Screenshot 2020-01-17 at 15 51 40

Other than that, I think we're ready to go.

zupo commented 4 years ago

Sorted.