search

teamreflex / oauth2-discord

OAuth2 client for authenticating with the Discord API servers
MIT License
61 stars 26 forks source link

Update league/oauth2-client dependency to version 2.2.1 #16

Closed Fusion86 closed 6 years ago

Fusion86 commented 7 years ago

Currently uses league/oauth2-client version 1.3 which in turn uses ircmaxell/random-lib version 1.1 which uses the mcrypt extension which is deprecated in PHP 7.1

Updating league/oauth2-client to version 2.2.1 solves this issue because it doesn't use ircmaxell/random-lib anymore (but a different package which doesn't use mcrypt).

shyim commented 7 years ago

Is here any news?

Fusion86 commented 7 years ago

This version works fine if you only use it in a 'Login with Discord' kind of way. I haven't tested the other functions but I believe at least some of them are broken.

RheaAyase commented 6 years ago

This PR would break the code, see the changelog for 2.0 version:

* Rename getResponse() to getParsedResponse()
* Add getResponse() method that returns the unparsed PSR-7 Response instance

And this is the thing I guess: https://github.com/teamreflex/oauth2-discord/blob/master/src/Discord/Discord.php#L127

Fusion86 commented 6 years ago

Hmm well that didn't work. It does look like all the errors thrown are completely unrelated though. Unfortunately I don't use this anymore but fortunately there are alternatives like RestCord, which should work.