Open SaidPar opened 6 years ago
Do we have a larger list of possible grades? It's going to be all the edge cases that get us.
What are you covering so far? I'll write up what I can think of when I get home.
So what I'm going to do is actually just build a grade normalizer. It will normalize grades so that they can be looked up in the database.
This is what I have so far:
before | after |
---|---|
5.10 | 5.10c (based on existing grade manager logic) |
5.10a | 5.10a |
5.10A | 5.10a |
5.10a/b | 5.10a |
5.7+ | 5.7d |
5.9- | 5.9a |
5.10a-b | 5.10a |
5.9-10 | 5.9d |
5.9easy | 5.9 (should be 5.9a?) |
I'm thinking maybe the default letter grade should be 'b'. So 5.10
-> 5.10b
. I'm thinking easier because usually the easier ones don't have letter grades?
There are also the danger ratings, pg13, r, x. We've been defaulting no later grade for 5.10 and up to b for simplicity, but we wanted to be smarter at some point and potentially slot them in to the pyramid where there are empty slots when it makes sense.
Also, we ignore all modifiers below 5.10, but that doesn't mean we have to
Are you handling bouldering grades yet?
I'm ignoring danger ratings.
We've been defaulting no later grade for 5.10 and up to b for simplicity
You sure? Looking at the code it seems like it's defaulting to c
.
Also, we ignore all modifiers below 5.10, but that doesn't mean we have to
Doesn't matter to me.
Are you handling bouldering grades yet?
Yep - no split grades though yet.
No not sure, I meant to default to b, but maybe I typed c
We need a reliable way to parse the many variations on grades: