search

teamsalta / sm64nx

Other
50 stars 10 forks source link

Some Minor Errors and Possible Fixes #33

Open novakirby opened 3 years ago

novakirby commented 3 years ago

  1. Error while zstd is also installed into python3 environment. https://github.com/teamsalta/sm64nx/blob/16763d610883adeec311d2d13ae2afb38b796c8b/scripts/pak.py#L10 Use zstandard instead of zstd.

  2. Compile error if VERSION is set to jp https://github.com/teamsalta/sm64nx/blob/16763d610883adeec311d2d13ae2afb38b796c8b/src/game/level_update.cpp#L532-L533 Should be port->node.destArea. (Already fixed in sm64 and sm64-port.)

  3. Should sm64 and sm64.exe in project root be removed? They may contain copyrighted contents as some assets were(?) directly linked into the executable.