teamspatzenhirn / rig_reconfigure

GUI tool for editing ROS 2 parameters at runtime
MIT License
79 stars 8 forks source link

Improvements for handling string parameters #18

Closed authaldo closed 1 year ago

authaldo commented 1 year ago

In the current version of rig_reconfigure, every character modification within a string parameter causes an update which is sent to the respective node.

This MR modifies the behaviour: An update is now only sent to the node if the editing is finished by pressing enter or the input field is deselected. For the future it might also be interesting to include a timeout which handles situations where the user has finished editing but forgets to press enter (and doesn't change the focus within the window). The timeout is not part of this MR but might be added in the future. Given the low usage of string parameters within our internal software stack, the timeout is currently solely a low priority enhancement.

The MR further includes minor layout changes which ensure that nesting doesn't cause textfields to span across the border of the window (if the window is large enough to handle the top level text fields).