search

teamswipp / swippcore

The Swipp core includes the QT wallet and the console daemon for the currency.
Other
9 stars 7 forks source link

Cold masternodes do not seem to work #1

Open phwconz opened 6 years ago

phwconz commented 6 years ago

In a typical coin which is capable of cold masternodes, the installation generates a masternode.conf file which the controller uses to identify the cold node. Swipp does not generate a masternode.conf file and if you do create one and use it in the way that you would to create a cold masternode, it does not work.

It appears that in order to create a masternode, it needs to be hot so that the required information can be input into the node's swipp.conf file instead.

teamswipp commented 6 years ago

Hello. There is masternode.conf handling in the source code (however, I have not tested it myself);

https://github.com/teamswipp/swippcore/blob/4439fa4ad5e7070a2cbbe83a8d1ca0dd2018fa9a/src/masternodeconfig.cpp#L13 https://github.com/teamswipp/swippcore/blob/4439fa4ad5e7070a2cbbe83a8d1ca0dd2018fa9a/src/rpcdarksend.cpp#L435

I need some more information. How do you start the masternode? Just editing masternode.conf isn't enough, you probably also need to call one of the start commands.

You should be able to see the parsed masternode.conf settings if you call;

/swippd masternode list-conf

Then you should be able to bring it up it with start-alias/startmany. If you run the start command and nothing happens, the debug log usually contains a hint to what went wrong.

phwconz commented 6 years ago

I don't have anymore coins for another masternode so I can't try starting a cold masternode. I tried for a while before the new team took over, so, unless you've specifically changed anything to do with how masternodes are implemented when you took over the code, the issue will still be present. I've started several other masternodes that use a masternode.conf file. All of those coins generate that file themselves when the wallet is first run. In my experience of trying to start a cold masternode with other coins that also don't generate a masternode.conf file, they've all failed to start. The normal procedure doesn't work.

teamswipp commented 6 years ago

Hi. I may have changed a few things, but not the way masternodes are started and configuration files are parsed. Not all wallets generate that file. In this case, the masternode.conf file is intentionally not generated, as it is only needed if you run a cold node or multiple nodes.

I did some quick testing and looked through it. Everything from that plus the the source code tells me that it should work. The configuration file is definitely parsed and used by the rpc command line.

I'll keep the issue open for a while, if anybody has any problems I hope they will let us know.

tsupinhua commented 6 years ago

I want to setup cold masternode . This means the VPS masternode itself doesn't hold any coins, they are all in my local wallet. masternode.conf should be found in win swipp wallet not in VPS.

this is other coin cold mn setup guide for reference https://docs.google.com/document/d/1nkdakiFwjl-WZNnZE960Ti5ETKpD0NLSlvhHpnBZh5c/edit

teamswipp commented 6 years ago

Hi @tsupinhua.

Yes, that guide is an alternative way of setting up a cold node without usingmasternode.conf and instead using the masternode functionality in the UI. Should work exactly the same with Swipp.

When you use masternode.conf you use the CLI/RPC interface.

phwconz commented 6 years ago

I need to setup my masternode again so I'm taking the chance to try launching this as a cold masternode. Running masternode list-conf doesn't return the masternode detailed in masternode.conf.

teamswipp commented 6 years ago

Hi @phwconz. Check the debug log to see if it fails to parse the config file.

If you are still struggling, I'll look into this after the new wallet release that I am currently preparing.

phwconz commented 6 years ago

I don't know what to look for unfortunately. I keep seeing this line though: 2017-12-09 08:19:24 dseep - Got bad masternode address signature CTxIn(COutPoint(155c8023a4, 1), scriptSig=)

I don't know if that's relevant or not. Basically, list-conf doesn't show anything which suggests to me that the masternode.conf file (that I made myself as it isn't created by default) is not being read. Sorry I can't be of any more help. If you do have a chance to look into it, that would be great.

teamswipp commented 6 years ago

@phwconz Looks to me like that error message is related to an external masternode trying to get in on the network with the wrong collateral. Most likely not related. I will look into this and report back here once I have.

teamswipp commented 6 years ago

I have now spent some time with this. As reported by @phwconz there were some issues with this, even though there is code to handle it in the code base.

I have a somewhat done fix for this that will make it into one of the next wallet updates. Keep an eye on this issue - it will be referenced and closed from the commit once it's added to master.