Breaking Change from #103 Option to use searchBoolean

teamtnt / laravel-scout-tntsearch-driver

Driver for Laravel Scout search package based on https://github.com/teamtnt/tntsearch

MIT License

1.1k stars 144 forks source link

Breaking Change from #103 Option to use searchBoolean #112

Closed tehwave closed 7 years ago

tehwave commented 7 years ago

Hi,

An ErrorException is thrown with the msg Undefined index: searchBoolean because theconfig/scout file doesn't have the following line introduced in the #103 pull request.

'searchBoolean' => env('TNTSEARCH_BOOLEAN', false),

The fix from a user standpoint would be to just include the line, but I rather not spend time fixing bugs from breaking changes introduced in patches, provided the package follows semver, which I'd encourage you to do very much.

-- Cheers

nticaric commented 7 years ago

I totally agree with you. We try to follow semver as much as possible, but it seems that this change somehow slipped through