The keys are passed as a collection and not as an array inside the map function

teamtnt / laravel-scout-tntsearch-driver

Driver for Laravel Scout search package based on https://github.com/teamtnt/tntsearch

MIT License

1.1k stars 144 forks source link

The keys are passed as a collection and not as an array inside the map function #27

Closed ba77osai closed 8 years ago

ba77osai commented 8 years ago

In the file TNTSearchEngine.php#152 in the map function, the keys are collected inside a collection and not as an array like in the examples from Laravel ( ElasticSearch#L233 )

That behaviour makes problems with other implementation, (example laravel-doctrine: Laravel-Doctrine#L141 ) where an array is expected.

Would it make a big problem to replace the keys to a normal array instead a collection?

nticaric commented 8 years ago

No problem, please create a pull request and we'll merge it.

nticaric commented 8 years ago

Thanks for the PR