search

teamtnt / laravel-scout-tntsearch-driver

Driver for Laravel Scout search package based on https://github.com/teamtnt/tntsearch
MIT License
1.09k stars 142 forks source link

Compatibility with Laravel Scout v9 #324

Closed limenet closed 3 years ago

limenet commented 3 years ago

First of all, thanks so much for this great Laravel Scout adapter!

In order to resolve #323 this PR adds implementations for the new abstract methods based on https://github.com/laravel/scout/blob/9.x/src/Engines/AlgoliaEngine.php.

Additionally, InvalidArgumentException is now used to ensure a proper exception is thrown in TNTSearchEngine::addFilter() (and not an exception saying the exception class could not be found).

Since the new methods were not used in previous versions of laravel/scout I don't expect any backwards compatibility issues.

Let me know if you'd like me to make any changes.

nticaric commented 3 years ago

Thanks!

limenet commented 3 years ago

That was quick 🚀, you're welcome!