Properly support pydantic v2

teamtomo / imodmodel

IMOD model files as pandas dataframes in Python

https://teamtomo.org/imodmodel/

Other

9 stars 7 forks source link

Properly support pydantic v2 #10

Closed uermel closed 5 months ago

uermel commented 5 months ago

At the moment this package works even when using pydantic v2, but produces a couple of deprecation warnings (primarily regarding the use of @validator-decorator).

It would be great to either

use the pydantic v2 interface that provides the v1 API (e.g. from pydantic.v1 import BaseModel)
completely migrate to pydantic v2 and bump the package version

I would offer to take this on, which approach is preferred?

alisterburt commented 5 months ago

Hey, nice to see you here @uermel ! I think v2 is well established now so more than happy to bump 🙂 I'll wait for your PR!

alisterburt commented 5 months ago

closed by #13