search

teamtomo / imodmodel

IMOD model files as pandas dataframes in Python
https://teamtomo.org/imodmodel/
Other
9 stars 7 forks source link

Parse SLAN Chunks #17

Closed braxtonowens closed 4 months ago

braxtonowens commented 5 months ago

SLAN chunks can now be parsed.

User specifies an annotation='slan' option for the slan annotations when converting to dataframe.

Testing added for:

  1. dataframe
  2. ImodModel
  3. _parse_slan()

Testing file added with slan annotations.

jojoelfe commented 5 months ago

Hey, this looks good. I made some minor changes to make 'contour' an explicit option for annotation (which is the default) and added some tests for edge cases.

For now trying to parse slans from a file that has none will raise an ValueError with a bit more helpful error message. I guess one could make an argument for returning an empty dataframe.

Let's wait 1-2 days if @alisterburt wants to chime in and then merge.

braxtonowens commented 5 months ago

Great! Thanks for making those changes. Definitely better than what I was doing.

alisterburt commented 4 months ago

v0.0.12 deployed https://github.com/teamtomo/imodmodel/actions/runs/9409613999