Closed braxtonowens closed 4 months ago
Wonderful - while we're at it, do you think the attribute should be .slan or .slicer_angles?
I'm fine with either but prefer the aesthetics of slicer_angles - if we go with slicer_angles can we update the selector for annotation type where it's 'slan' too?
Great work as always @braxtonowens !
Looks like you have some merge conflicts, you'll have to rebase on main
Yeah, I like slicer_angles better.
@braxtonowens I've given you maintenance powers on the repo - let's still discuss things over PRs with the other but you're doing a great job and should have the ability to move the project forward 🙂
Would you like to trigger the deployment workflow with this new code so that it's available on PyPI?
The deployment workflow is stored here: https://github.com/teamtomo/imodmodel/blob/5908efc1993ff076bc6196ac992a5bf20476c4c3/.github/workflows/test_and_deploy.yml#L1-L76
If you take a look at that workflow you'll see it is trigger when a 'tagged commit' matching 'v*' is pushed to the main branch. Deploying will look like:
Once you do this, you should see things launch in the actions tab of the repository https://github.com/teamtomo/imodmodel/actions
If you don't want to do this let me know and I'm happy to do it too - only written up in case you would like to learn
Great, I think everything went smooth for v0.0.13. Thanks for the help.
Great!!
I incorrectly made Slicer angles an
ImodModel.object
attribute in #17. It is now anImodModel
attribute. IMAT is now anImodModel.object
attribute instead of anImodModel
attribute.Added mod file with multiple objects along with testing.
Added documentation for using
ImodModel
.