teamtomo / imodmodel

IMOD model files as pandas dataframes in Python
https://teamtomo.org/imodmodel/
Other
8 stars 6 forks source link

Support writing mod files #9

Open hanjinliu opened 6 months ago

hanjinliu commented 6 months ago

Hi teamtomo members, is there any plans to support writing a ImodModel into a mod file? It'll be very nice if we can fully handle models on Python side.

alisterburt commented 5 months ago

Hey @hanjinliu ! Nice to see you here 😀

I don't have immediate plans to add this myself but would gladly accept a PR if someone else were to add support

hanjinliu commented 5 months ago

Hi @alisterburt , hope you're doing well!

I'll send a PR if I could figure out how to do that, as I eagerly wanting this 😄

alisterburt commented 5 months ago

Nice! It should definitely be possible it just might be a little tedious going through the binary specification

Don't worry about the PR being finished before opening if you do open it up, happy to work on it a bit together :)

MoritzWM commented 5 months ago

I'll also gladly help you implementing this

bbarad commented 2 months ago

I am interested in this in order to routinely load my surface morphometrics meshes into imod, but I couldn't find any existing PR or progress on this - did I miss something? If not, I'll start with meshes (because of course thats the use case I need!) and open a PR and maybe we can expand from there before doing the full incorporation. Does that seem like a reasonable route forward?

alisterburt commented 2 months ago

I haven't seen any existing work yet but there's clear interest! If you want to jump on zoom this afternoon and work on it @bbarad id be down

alisterburt commented 2 months ago

Path forwards sounds reasonable

bbarad commented 2 months ago

I appreciate the offer but I gotta spend today on personal stuff before I travel again - maybe we can find a time later in the week once I am back at OHSU though!

alisterburt commented 2 months ago

Makes sense - I'm down but would have to be outside of work hours