search

teamtomo / membrain-seg

membrane segmentation in 3D for cryo-ET
Other
47 stars 12 forks source link

Fixed output filename formatting which assumed the extension was always 3 characters long #43

Closed rdrighetto closed 6 months ago

rdrighetto commented 6 months ago

Someone tried to run membrain-seg on a tomo with .em extension and then we found this bug in the output filename. Using os.path.splitext() fixes it.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d76e97e) 6.62% compared to head (6a1d2a4) 5.41%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #43 +/- ## ======================================== - Coverage 6.62% 5.41% -1.22% ======================================== Files 38 38 Lines 1313 1256 -57 ======================================== - Hits 87 68 -19 + Misses 1226 1188 -38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LorenzLamm commented 6 months ago

Looks good, thanks for implementing! :)