fix warnings in tests - Githubissues

teamtomo / starfile

STAR file I/O in Python

https://teamtomo.org/starfile/

BSD 3-Clause "New" or "Revised" License

44 stars 19 forks source link

fix warnings in tests #51

Closed alisterburt closed 8 months ago

alisterburt commented 9 months ago

pandas will require pyarrow in the future
delim_whitespace is being removed in pd.read_csv

alisterburt commented 8 months ago

hey @jojoelfe - you're right this is the PR that's giving me trouble.

Summary:

there's a deprecation in pandas, they're removing delim_whitespace in favour of sep/delimiter``=\s+
the behaviour isn't equivalent to delim_whitespace for some of our empty string tests and breaks them

jojoelfe commented 8 months ago

Hey, just pushed a PR against the pyarrow branch. I think the problem was somewhere else. Before I was resetting columns that contain only NaNs to their original string, but that ment setting a column of type float to a string. Now the whole columns are being replaced, which also replaces the dtype.

alisterburt commented 8 months ago

all green, let's goooo