search

teamtomo / starfile

STAR file I/O in Python
https://teamtomo.org/starfile/
BSD 3-Clause "New" or "Revised" License
44 stars 19 forks source link

Fix NaN parsing #69

Closed jojoelfe closed 2 weeks ago

jojoelfe commented 2 weeks ago

Initial draft for fix of #68, I think the solution is valid, but the test could be more comprehensive.

codecov-commenter commented 2 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.73%. Comparing base (5b19406) to head (7aeb97e). Report is 17 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #69 +/- ## ========================================== + Coverage 80.93% 82.73% +1.80% ========================================== Files 7 7 Lines 278 307 +29 ========================================== + Hits 225 254 +29 Misses 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alisterburt commented 2 weeks ago

Test fail is a writing speed test, I'm unsure how this would be affected by this PR so still ok