search

teamwalnut / graphql-ppx

GraphQL language primitives for ReScript/ReasonML written in ReasonML
https://graphql-ppx.com
MIT License
257 stars 53 forks source link

pollInterval None should cancel polling? #248

Closed AlexMoutonNoble closed 3 years ago

AlexMoutonNoble commented 3 years ago

Hi folks. I have been using react state to gate pollInterval on some queries, as some tasks progress on the back end. It took me a while to figure that None does not cancel a set interval. Should it? It seems like it should?

Seems likely a one liner. I can take a look if youre interested in a PR.

Thanks Alex

jfrolich commented 3 years ago

you probably want to file an issue in https://github.com/reasonml-community/rescript-apollo-client

AlexMoutonNoble commented 3 years ago

ah yep! thanks

On Mon, Mar 8, 2021 at 8:16 PM Jaap Frolich notifications@github.com wrote:

Closed #248 https://github.com/reasonml-community/graphql-ppx/issues/248 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/reasonml-community/graphql-ppx/issues/248#event-4425165151, or unsubscribe https://github.com/notifications/unsubscribe-auth/APRNFBSCJYQWHHZBFOS65P3TCWOJRANCNFSM4Y2VUMVQ .