search

teamwalnut / graphql-ppx

GraphQL language primitives for ReScript/ReasonML written in ReasonML
https://graphql-ppx.com
MIT License
257 stars 53 forks source link

Remove `yarn.lock` file from repository #260

Closed Kingdutch closed 3 years ago

Kingdutch commented 3 years ago

The repository contains both a package-lock.json and yarn.lock file. These files are not used by packages requiring graphql-ppx but only by contributors. The contributing guidelines tell us to use npm install.

When using yarn install it produces the following warning.

package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.

To be clearer to contributors, avoid the error that yarn points to and match the contributing guidelines it makes sense to remove yarn.lock and standardise on npm for development.

jfrolich commented 3 years ago

Sounds like a great idea. PR welcome, if you want to contribute it.