teamwalnut / graphql-ppx

GraphQL language primitives for ReScript/ReasonML written in ReasonML
https://graphql-ppx.com
MIT License
257 stars 53 forks source link

Convert to OCaml #274

Closed jfrolich closed 2 years ago

baransu commented 2 years ago

Oh man, what a full circle it is 😮

jfrolich commented 2 years ago

Oh man, what a full circle it is 😮

Yes it is! Given the situation with ReasonML I think this is the more stable path, and the ReScript core team would really like to see ppx's being written in pure OCaml. I also would like to split the repo in a native and ReScript version so I figured I do the conversion first, so it's easy to have cherry-pick improvements.

anmonteiro commented 2 years ago

There's a benefit of keeping both native and ReScript code together, as features won't deviate from one another. Am I misunderstanding the split and do you have a good solution for this in mind?

jfrolich commented 2 years ago

There's a benefit of keeping both native and ReScript code together, as features won't deviate from one another. Am I misunderstanding the split and do you have a good solution for this in mind?

I want to use the rescript compiler hooks instead of ppxlib, that is the direction the ReScript team is going. Any idea how to do that while not splitting the codebase?

I think potentially it could be done with some dune build tool tricks, will explore