teamwalnut / graphql-ppx

GraphQL language primitives for ReScript/ReasonML written in ReasonML
https://graphql-ppx.com
MIT License
257 stars 53 forks source link

Reintroduce workaround for arm64 to use rosetta #278

Closed JonoPrest closed 2 years ago

JonoPrest commented 2 years ago

HI @jfrolich and graphql-ppx team!

I would like to open a pull request to reintroduce this work around for arm64 macs to be able to use rosetta.

I'm not entirely sure what the reasoning for removing this workaround was on the latest update but I would be a very appreciative developer if it could be reintroduced.

I have also modified the if statement to only check whether process.arch is "arm64" and not to specifically require process.platform to equal "darwin". This is because using the new optimized docker for apple silicon one could be running a container with linux in an arm64 environment for example and it would still work perfectly using the graphql-ppx-linux-x64.exe.

This has been the case for me on a current project and I've had code in a virtual environment in order to work with graphql-ppx.

Thanks very much.