search

tebru / gson-php

Gson implemented in PHP
Other
151 stars 18 forks source link

fix(dependencies): require explicitly psr/simple-cache #37

Closed Gounlaf closed 5 years ago

Gounlaf commented 5 years ago

Add dependency to psr/simple-cache manually, and force symfony/cache to be < 4.3

natebrunette commented 5 years ago

Changing the minimum version is a breaking change.

Gounlaf commented 5 years ago

Current package was allowing symfony 4.0 to 4.x, less than 4.5

Here I just fix the scope to <4.3

The breaking change is done in the other PR (I haven't fixed it correctly so CI failed) where I actually change the minimum version

Gounlaf commented 5 years ago

Hi @natebrunette,

To avoid breaking change, I've created a CacheProvider class that will provide appropriate class, depending on Symfony version.

The unit tests part is quite ugly now (had to use Reflection)

natebrunette commented 5 years ago

What is this fixing?

Gounlaf commented 5 years ago

What is this fixing?

Current composer definitions permit large version of Symfony 4.x Since 4.3, cache classes has been rewritten - and psr/simple-cache need to be required manually.

Since previous commit was a breaking change - you said Changing the minimum version is a breaking change, I had to find a way to be compatible with Symfony >= 4.3

javadev commented 5 years ago

This branch has conflicts that must be resolved

natebrunette commented 5 years ago

resolved with : #43