search

tecbot / gorocksdb

gorocksdb is a Go wrapper for RocksDB
http://rocksdb.org
MIT License
940 stars 269 forks source link

Gorocksdb now requires master of Rocksdb #175

Closed vitalyisaev2 closed 4 years ago

vitalyisaev2 commented 5 years ago

@tecbot @JelteF this is caused by #162

C API functions introducted by this MR are still not released after 5 months. I can't find them in the latest release: https://github.com/facebook/rocksdb/blob/v6.2.4/include/rocksdb/c.h (by the way, why does it take so long?)

Now gorocksdb can be only compiled with the master of rocksdb. This may decrease stability of the software that uses gorocksdb. I think that we should look towards go.mod and synchronize tags in gorocksdb with the releases of rocksdb. At least, the README of gorocksb must notice that master of rocksdb is requried (5.16+ is misleading).

tecbot commented 5 years ago

@vitalyisaev2 I have reverted #162 for now. Versioning to sync with upstream is a good idea, @jamesbibby how you handle this?

jamesbibby commented 5 years ago

I suggest we open a branch for the new 6.2.4 release of RocksDB and make an effort to implement the full C api available at that point. From there we can try to have master reflect the latest versioned release and keep the README up to date. As for supporting prior releases, we could tag RocksDB versions so that people have a stable version to pull for a particular release (though we may not keep up with bug fixes on prior releases). Does that make sense?

The versioned release schedule for RocksDB is not really something we can control , however, I have opened a question in the dev group (on FB)