tecbot / gorocksdb

gorocksdb is a Go wrapper for RocksDB
http://rocksdb.org
MIT License
937 stars 269 forks source link

Moving rocksdb v8 compatible code into a v8 folder. #233

Closed jamesbibby closed 5 months ago

jamesbibby commented 5 months ago

We cannot specify a go version higher than 1.16 if we keep the code in a go.mod free setup. If we want to include a go.mod, all versions higher than v1 need to be in a vX folder.

2 options:

First is this, move the rocksdb v8 compatible code into a /v8 folder and keep our versioning scheme.

Second, change our versioning scheme to use 1.8 for rocksdb 8 compatible code.

Although I hate the idea of duplicating the code, I think the first option makes the most sense as we can actually check the incompatible code back into master and go can resolve the versions separately without using gopkg.in. With v8 already in a branch it is not really possible to merge to master without breaking everyone anyway.