Open janschab opened 1 year ago
hello, onInit hook calls this.iconPickerSelect.emit(this.iconPicker);. Does it serve any purpose? Imo event should only be sent when there is a icon change.
this.iconPickerSelect.emit(this.iconPicker);
ngOnInit() { this.iconPicker = this.iconPicker || this.ipFallbackIcon || 'fa fa-user-plus'; this.iconPickerSelect.emit(this.iconPicker); }
I would be grateful if I could contribute and do PR that will make emitting event optional in onInit.
@Input() emitEventOnInit: boolean = true; ngOnInit() { this.iconPicker = this.iconPicker || this.ipFallbackIcon || 'fa fa-user-plus'; if (this.emitEventOnInit) { this.iconPickerSelect.emit(this.iconPicker); } }
hello, onInit hook calls
this.iconPickerSelect.emit(this.iconPicker);
. Does it serve any purpose? Imo event should only be sent when there is a icon change.I would be grateful if I could contribute and do PR that will make emitting event optional in onInit.