Angular 17 peer dependencie issue

boban100janovski commented 6 months ago

I am getting the warning below when using Angular 17. I think the fix could be to update the "lib" package.json dependencie settings:

 "@angular/common": "^16", => "@angular/core": ">=16"
 "@angular/core": "^16",

Waring:

npm WARN While resolving: ngx-icon-picker@1.11.2
npm WARN Found: @angular/common@17.0.3
npm WARN node_modules/@angular/common
npm WARN   peer @angular/common@"^17.0.0 || ^18.0.0" from @angular/cdk@17.0.3
npm WARN   node_modules/@angular/cdk
npm WARN     peer @angular/cdk@"17.0.3" from @angular/material@17.0.3
npm WARN     node_modules/@angular/material
npm WARN     1 more (the root project)
npm WARN   10 more (@angular/forms, @angular/google-maps, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer @angular/common@"^16" from ngx-icon-picker@1.11.2
npm WARN node_modules/ngx-icon-picker
npm WARN   ngx-icon-picker@"^1.11.2" from the root project
npm WARN
npm WARN Conflicting peer dependency: @angular/common@16.2.12
npm WARN node_modules/@angular/common
npm WARN   peer @angular/common@"^16" from ngx-icon-picker@1.11.2
npm WARN   node_modules/ngx-icon-picker
npm WARN     ngx-icon-picker@"^1.11.2" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: ngx-icon-picker@1.11.2
npm WARN Found: @angular/core@17.0.3
npm WARN node_modules/@angular/core
npm WARN   peer @angular/core@"17.0.3" from @angular/animations@17.0.3
...

My package.json:

 "dependencies": {
    "@angular/animations": "17.0.3",
    "@angular/cdk": "17.0.3",
    "@angular/common": "17.0.3",
    "@angular/compiler": "17.0.3",
    "@angular/core": "17.0.3",
    "@angular/forms": "17.0.3",
    "@angular/google-maps": "^17.0.3",
    "@angular/material": "17.0.3",
    "@angular/material-date-fns-adapter": "17.0.3",
    "@angular/platform-browser": "17.0.3",
    "@angular/platform-browser-dynamic": "17.0.3",
    "@angular/router": "17.0.3", 
    "@ngrx/component-store": "17.0.1",
    "@ngrx/effects": "17.0.1",
    "@ngrx/entity": "17.0.1",
    "@ngrx/router-store": "17.0.1",
    "@ngrx/store": "17.0.1",
    "@nx/angular": "17.2.8", 
    "lodash-es": "^4.17.21",
    "ngx-icon-picker": "^1.11.2",
    "rxjs": "~7.8.0",
    "tslib": "^2.3.0",
    "zone.js": "0.14.2"
  }

Bregi commented 6 months ago

Same issue here

boban100janovski commented 6 months ago

@Bregi you should be able to fix the issue by adding an override in package.json,

"overrides": { "ngx-icon-picker": { "@angular/common": "$@angular/common", "@angular/core": "$@angular/core" } }

Bregi commented 6 months ago

@boban100janovski great, thanks for this, wasn't aware of this (temporary) possibility

tech-advantage / ngx-icon-picker

Angular 17 peer dependencie issue #89