search

tech-systems / panes

🎉📱 Create dynamic modals, cards, panes for your applications in few steps. One instance – Thousands solutions. Any framework and free.
https://panejs.com
MIT License
681 stars 40 forks source link

[BUG] fitHeight not set height #225

Closed ArseniyXaoc closed 7 months ago

ArseniyXaoc commented 11 months ago

If set fitHeight = true, The panel size becomes larger than the window size and goes down, the scrolling of the internal content does not appear.

<div class="pane" style="transform: translateY(0px) translateZ(0px); height: unset; cursor: grab; transition: initial;"><ion-drawer style="display: block; transition: opacity 300ms ease 0s; overflow-x: hidden; height: unset; visibility: unset; pointer-events: unset;">

roman-rr commented 9 months ago

@ArseniyXaoc Please share repo, code or reproduction environment on jsfiddle or similar, so I can help quickly.

bghub1 commented 9 months ago

Hi @roman-rr I'm getting the same missing scroller issue when using fitHeight feature. It can be replicated on your auto height fiddle example https://jsfiddle.net/romantonoff/b4s5kjdr/ (just populate more text to trigger overflow)

image

roman-rr commented 9 months ago

@ArseniyXaoc @bghub1 It should be fixed in tag v.1.4.21 please try.

bghub1 commented 8 months ago

Hi, @roman-rr I'm still experiencing the same issue after updating to 1.4.21. Scroller only seems to work properly if FitHeightModule module is disabled.

roman-rr commented 8 months ago

@bghub1 Sorry for late reply. Please check this example https://jsfiddle.net/romantonoff/xzg2aedq/ Here is scroll available from panne initialization, when the height is more than window. fitHeight is enabled on this example and version is 1.4.21 using.

bghub1 commented 7 months ago

Hi, @roman-rr I've retested it and it's now working as expected 🎉 Thank you