search

tech5usa / TLSential

A server for providing short-lived TLS certificates to all services within a firewall restricted network.
GNU General Public License v3.0
15 stars 2 forks source link

Trigger cert issues and renewals by sending to a channel so that they… #72

Closed debus closed 4 years ago

debus commented 4 years ago

… can all be handled by the autoRenewal function

This PR addresses the following issues:

Fixes #31

Testing

Made sure all of the api calls function as expected

d1str0 commented 4 years ago

But yeah, as is, main problem is the unbuffered channels will cause a blockage in the http handlers. Also, we should check to see if the channel is full, and if so return a 4xx of too many requests https://stackoverflow.com/questions/25657207/how-to-know-a-buffered-channel-is-full

d1str0 commented 4 years ago

This adds several acme specific things to the Service package but not necessarily to the acmeService. I think they should become dependents of acmeService rather than free floating in package service. (It’s late, i can expand more tomorrow)