search

techahold / rustdeskinstall

Easy install Script for Rustdesk
MIT License
357 stars 110 forks source link

fix typo #10

Closed osiktech closed 2 years ago

osiktech commented 2 years ago

fix typo in line 91

osiktech commented 2 years ago

By my mistake I added a typo. Missing quote before keyreg. Also during the merge of my first PR enable-audio was somehow "messed up".

dinger1986 commented 2 years ago

I thought I should enable audio as I pulled the rustdesk2.toml from my pc originally and guessed I had disabled it at some point, I only noticed it when looking at your PR.

osiktech commented 2 years ago

I'm thinking of creating parameters to pass to the powershell script. This way we could set a default length for the password or create a longer one as I prefer. Also things like wanip and keyreg as well as enable-audio could be maintained this way. but this might conflict with install.sh.

dinger1986 commented 2 years ago

sounds good, it wont conflict, shall maybe just need to escape some of it so the variables arent changed.