search

techahold / rustdeskinstall

Easy install Script for Rustdesk
MIT License
357 stars 110 forks source link

parameterise variables wanipreg and keyreg #11

Closed osiktech closed 1 year ago

osiktech commented 2 years ago

Use parameters to install RustDesk client via script.

Provide a basic synopsis about the script

osiktech commented 2 years ago

hi @dinger1986 as promised a parameterised version of the script. I tested it and it should work out of the box with the install.sh script to install the server.

Nonetheless please test carefully before merging. :)

dinger1986 commented 2 years ago

ah ok, so someone would use the parameters to run the script? so we need to show the command to run it as well then I guess

osiktech commented 2 years ago

yes but this part of the powershell script. I put some examples in the head section of the WindowsAgentAIOInstall.ps1.

dinger1986 commented 2 years ago

lol yeah, have you met users? majority of people dont read basic instructions. Ill test it, I am sure it should be fine, we can always write instructions on the readme and give an example when the install script completes or something 👍

osiktech commented 2 years ago

18 years administration on my back, so yeah I have met users 😄. Testing is always welcome 👍

osiktech commented 2 years ago

btw Get-Help .\WindowsAgentAIOInstall.ps1 should also print some help. I'm not a powershell pro, rather on the UNIX side of the world.

dinger1986 commented 2 years ago

nice one, yeah I am the same, prefer the unix side of things :) its so hard working with them now

dinger1986 commented 2 years ago

Been thinking about this and think it should be a different script, so should be WindowsAgentStandaloneInstall.ps1 or something, guess just need to compare what other changes have been made etc, sorry about this