search

techahold / rustdeskinstall

Easy install Script for Rustdesk
MIT License
330 stars 105 forks source link

install.sh: quality-of-life improvements #43

Closed amyipdev closed 1 year ago

amyipdev commented 1 year ago

This patch makes the following modifications:

[patch 1/3] Has users run the script as root instead of using sudo inside, to avoid several problems [patch 2/3] Fails out if a command fails, avoiding unknown-state issues [patch 3/3] Allows users to continue on unsupported operating systems without having dependencies satisfied

Signed-off-by: Amy Parker apark0006@student.cerritos.edu

dinger1986 commented 1 year ago

thanks!

amyipdev commented 1 year ago

@dinger1986 there is of course a solution: have a cli arg instead of using whoami if someone wants to manually set the user...

sudo should not be used in scripts except for very limited purposes, and this is not a "very limited purpose", this is abusing sudo to get around permissions restrictions

which means that, once again, this script cannot be run on systems without sudo - such as standard debian containers, or doas-based systems