add -ll to log full listener

[elpie89]

added option to display the complete result of the max listener using the native logger of user preferred ide/editor

tested with pycharm

[JeffHanna]

Elpie89,

I love the idea of this. I'd like to see two changes, though.

• Ensure the log file is deleted - either before each time it is accessed or when MXSPyCOM.exe exits. I am unable to find C# docs on an openLog( ) method in either System.IO or System.Text - the two .NET Classes for which you added using directives. So, I'm unclear as to whether openLog( ) auto-manages the disk file or if that must be done explicitly.
• Make this not an extra argument but something that just happens as a matter of course. Adding to the try block of the -f case would be a good location for it.

Also, please ensure you're matching whitespace settings (tab-3). The diffs on your pull-request Program.cs file encompass the entire file, not just the additions you made.

I really do like this Idea. I'm looking forward to your next pull request. Thank you very much for contributing!

[elpie89]

ok, I'll improve it asap, I see your point.

[elpie89]

Hi Jeff, looking on the behaviour of the openlog command I saw that actually, the command itself delete the old file and create a new one every time the command is called. Practically every time we will run a command from the MXSPyCOM with the -f argument a new file will be created/overwritten

Also, the closelog command ensure only the last MXSPyCOMcommands are registered and avoid the log to store commands executed manually in the listener by the user The only case that a log file is open and the size of the file increase is when MXSPyCOM run the command openLog and than do not run the closeLog (i don't think this could happen)

We could eventually delete the file before MXSPyCOM return ,but I think it is a good idea to keep the log accessible from outside. If you do not agree I will add the "delete log " right before the return statements

[JeffHanna]

Hi.

I'm sorry for the delay in responding. Between some Memorial Day weekend plans and a few family issues that cropped up I've not been as attentive to this as I should've been.

If openLog( ) is self maintaining and won't bloat a user's storage, great! Let's go with that, then. I agree with your idea to not forcibly clean up the log file if that is not necessary. Having that data available to aid in debugging would be a benefit.

Jeff

On Mon, May 13, 2019 at 4:54 AM elpie89 notifications@github.com wrote:

Hi Jeff, looking on the behaviour of the openlog command I saw that actually, the command itself delete the old file and create a new one every time the command is called. Practically every time we will run a command from the MXSPyCOM with the -f argument a new file will be created/overwritten

Also, the closelog command ensure only the last MXSPyCOMcommands are registered and avoid the log to store commands executed manually in the listener by the user The only case that a log file is open and the size of the file increase is when MXSPyCOM run the command openLog and than do not run the closeLog (i don't think this could happen)

We could eventually delete the file before MXSPyCOM return ,but I think it is a good idea to keep the log accessible from outside. If you do not agree I will add the "delete log " right before the return statements

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/techartorg/MXSPyCOM/pull/7#issuecomment-491756463, or mute the thread https://github.com/notifications/unsubscribe-auth/AABE3V2KTM4GUFGCSLOAD7TPVE3DRANCNFSM4HK4OI5Q .

[elpie89]

no problem Jeff. I'm glad to help the community