remove win32 dependency in favor of ctypes

techartorg / bqt

A Blender add-on to support & manage Qt Widgets in Blender (PySide2)

https://github.com/techartorg/bqt/wiki

Mozilla Public License 2.0

162 stars 23 forks source link

remove win32 dependency in favor of ctypes #23

Closed hannesdelbeke closed 1 year ago

hannesdelbeke commented 2 years ago

this PR continues on the work from @friedererdmann his PR It removes the dependency on win32gui but without adding a new dependency on keyboards.

less dependencies is better, since less chance for issues and errors
this prevents dependency bugs, example mentioned here:

This is because the pywin32 dependency is not installed.

https://github.com/techartorg/bqt/blob/8437e061b74f1a692ef16b2174144cf5e25120f2/setup.py#L91

Currently, you can make it work by manually installing pywin32.

hannesdelbeke commented 1 year ago

just having a quick reread, think we can remove pypiwin32 from requirements? @friedererdmann

friedererdmann commented 1 year ago

just having a quick reread, think we can remove pypiwin32 from requirements? @friedererdmann

Yes, it should no longer be required :)

friedererdmann commented 1 year ago

Can also remove the dependency in setup.py (line 43ff)

        # Install pypiwin32 through a separate process since setuptools.setup() can not
        # properly handle the install for an unknown reason compared to a straight pypi install.
        Popen([sys.executable, "-m", "pip", "install", "pypiwin32"])

ewerybody commented 1 year ago

Is anybody maintaining this?

hannesdelbeke commented 1 year ago

I'm maintaining this PR ;) And we are in talks with the repo maintainers to add aditional people for the repo