search

techartorg / bqt

A Blender add-on to support & manage Qt Widgets in Blender (PySide2)
https://github.com/techartorg/bqt/wiki
Mozilla Public License 2.0
162 stars 23 forks source link

support both pyside2 and pyqt5 #25

Closed hannesdelbeke closed 1 year ago

hannesdelbeke commented 1 year ago

Currently bqt is tied to pyside2 If we want to use pyqt5, bqt won't work. 😞 this PR adds support for both, using Qt5

but do we want this to live inside this repo, so people can just drag n drop all code into blender and it works? or do we want to only support pip install, and not include qt5 itself in this repo?

This needs discussion on future direction of bqt, @friedererdmann @bob-white @Amatobahn

friedererdmann commented 1 year ago

Hey! From the looks of it this is the abstraction is very much like Qt.py, correct? If that's the case, should we consider pushing these binding updates to Qt.py and consume from there instead?

hannesdelbeke commented 1 year ago

(this PR also includes sys arg passing to QT modules) moved that to a separate PR which we can merge in first https://github.com/techartorg/bqt/pull/26

hannesdelbeke commented 1 year ago

Hey! From the looks of it this is the abstraction is very much like Qt.py, correct? If that's the case, should we consider pushing these binding updates to Qt.py and consume from there instead?

hey, believe this might be related to a newer version of python in blender, or maybe a qt incompatibility . I used to use qt.py for everything. so think why i didn't here was cause I ran into issues. would have to test again since it's been a while

qt5 is more recent than qt.py they serve the same purpose. qt.py can handle more qt versions, but believe this is because marcus did some hacks for some of the new libs whereas qt5 is clean without hacks

hannesdelbeke commented 1 year ago
hannesdelbeke commented 1 year ago

tbh think for now we can just leave it with pyside2, and I could remove this qt conversion from the alt tab PR. Don't think this change is vital.