search

techascent / tech.ml.dataset

A Clojure high performance data processing system
Eclipse Public License 1.0
680 stars 35 forks source link

inconsistency between printed shape and `shape` function #407

Closed behrica closed 2 months ago

behrica commented 6 months ago

It at least surprised me to see that the shape is flipped when printing the dataset:

https://github.com/techascent/tech.ml.dataset/blob/b0896cc6116ad6aa049fb7f1b955e9fe49b07ae8/src/tech/v3/dataset/print.clj#L336

so I report it here.

cnuernber commented 6 months ago

dtype-next is row-major. All dataset libraries I tested output their shape in column-major form. This is why the reverse.