techascent / tech.ml.dataset

A Clojure high performance data processing system
Eclipse Public License 1.0
662 stars 33 forks source link

Protocol method return type hints can't be primitive #409

Open puredanger opened 3 months ago

puredanger commented 3 months ago

As we were working on this issue https://clojure.atlassian.net/browse/CLJ-2698, we were looking in the world for cases of defprotocol methods with ^double and ^long return type hints (which are not valid - protocol methods always return Object) and found PRowCount and PColumnCount in tech.v3.dataset.protocols - I would recommend removing those type hints as they are not valid. But FYI, I am not expecting any change in behavior in Clojure in 1.12.

harold commented 3 months ago

:+1: Thanks for the heads up!