techcorridorio / techcorridorio.github.io

Official site for techcorridor.io
http://www.techcorridor.io/
MIT License
13 stars 9 forks source link

Refactor meetup api #6

Closed caseywatts closed 9 years ago

caseywatts commented 9 years ago

I love the work @uncompiled did on this! :D In this PR I'm just cleaning up the code some, functionality isn't much changed.

I've extracted it into parts:

I'm pretty excited about this refactor because now we have a drop-this-in kinda web componenty thing going on. This is something another group could drop in and it would just about work for them! Maybe extracting configuration to an object would be a helpful next step.

caseywatts commented 9 years ago

I went ahead and just extracted configuration to an object, that's easy enough :)

benjaminoakes commented 9 years ago

This is going a good direction. I think we should avoid window.onload in favor of $(document).ready(fn) or $(fn) though. That's a next step to consider. :smile: