techfaqs / Tech-FAQs

Easy introductions to few important, simple, tech topics.
MIT License
8 stars 14 forks source link

added RNN implementation using tf 2.0 #69

Closed soumya997 closed 3 years ago

soumya997 commented 3 years ago

Hi, @animenon I have added RNN implementation of tf 2.0 under ML_AND_DL/tensorflow_2 . issue number #12 Please add hacktoberfest-accepted before merging 😃

animenon commented 3 years ago

@soumya997 I see that you have added a ipynb, the repo is for documents so it would be better is you could use markdown(.md) to document the required steps for a beginner. You can keep the notebook but a markdown with the details would be ideal.

soumya997 commented 3 years ago

Ok, sir (@animenon) I will change and make a md version of it. I guess you need to add the hacktoberfest-accepted label, not hacktoberfest. and is the documentation of my notebook ok, or do I have to make some changes? Should add the outputs of a cell along with the code too?

animenon commented 3 years ago

@soumya997 yes do add the outputs to the ipynb.

Note: The label required in hacktoberfest as this repo follows the approval process (read doc).

animenon commented 3 years ago

You don't need to raise a new PR for each change, just update the existing PR. Read about Git here: Git - version control