search

techfaqs / Tech-FAQs

Easy introductions to few important, simple, tech topics.
MIT License
8 stars 14 forks source link

added RNN implementation using tf 2.0.md #70

Closed soumya997 closed 3 years ago

soumya997 commented 3 years ago

Hi, @animenon I have added RNN implementation of tf 2.0 in markdown format under ML_AND_DL/tensorflow_2. issue number #12 Please add hacktoberfest-accepted label, not hacktoberfest before merging 😃. I kept the cell outputs in the doc too.

soumya997 commented 3 years ago

Sir @animenon , I guess you need to add hacktoberfest-accepted label, not hacktoberfest . If it's not hacktoberfest-accepted then my contribution won't be accepted by hacktoberfest. 👈👈👈

soumya997 commented 3 years ago

Sir @animenon you can check now, I have made the changes

animenon commented 3 years ago

Sir @animenon , I guess you need to add hacktoberfest-accepted label, not hacktoberfest . If it's not hacktoberfest-accepted then my contribution won't be accepted by hacktoberfest. 👈👈👈

Don't worry, it will be considered.

This repo follows a standard review process hence hacktoberfest is to be used in place of hacktoberfest-accepted. From the hacktoberfest doc for your reference:

A maintainer can accept your PR by merging it, adding the "hacktoberfest-accepted" label to it, or approving it.

I will be approving your PR with hacktoberfest label and that will be it.

animenon commented 3 years ago

Sir @animenon you can check now, I have made the changes

Pls skip the Sir. Thanks.

soumya997 commented 3 years ago

Sir @animenon you can check now, I have made the changes

Pls skip the Sir. Thanks.

Ok, Actually, I said that because I saw your profile on LinkedIn, and in the future, I also want to build my career in the Data Science field.

animenon commented 3 years ago

Yes, do a git pull and merge. Then you will have the latest changes from here, after that you can do your changes.

animenon commented 3 years ago

@soumya997 be quick so that we can close this in October.

soumya997 commented 3 years ago

@soumya997 be quick so that we can close this in October.

@animenon I have made some changes please check it here and confirm it's ok or not. If it's ok then I will push the changes.

animenon commented 3 years ago

@soumya997 mostly looks good, just few pyhton blocks seem a little off. Also you could use <sup></sup> and <sub></sub> for super script and subscript in the formula. Anyway push it will, will fix and merge.

soumya997 commented 3 years ago

@soumya997 mostly looks good, just few pyhton blocks seem a little off. Also you could use <sup></sup> and <sub></sub> for super script and subscript in the formula. Anyway push it will, will fix and merge.

Was not able to do anything regarding the python code, but usedsub and sup to adjust the formula.

soumya997 commented 3 years ago

I am really very sorry for creating a new branch, I was having some conflicts.

animenon commented 3 years ago

72