fix leaked errors in loki-fs-structured adapter.

techfort / LokiJS

javascript embeddable / in-memory database

http:/techfort.github.io/LokiJS

MIT License

6.75k stars 481 forks source link

fix leaked errors in loki-fs-structured adapter. #799

Closed josh-sachs-epic closed 5 years ago

josh-sachs-epic commented 5 years ago

this PR implements proposed fixes to the loki-fs-structured adapter to prevent it from leaking errors when loading and parsing a database's container file.

josh-sachs-epic commented 5 years ago

just to close the loop, the corresponding issue is described here: https://github.com/techfort/LokiJS/issues/800

techfort commented 5 years ago

LGTM, merge away

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

josh-sachs-epic commented 5 years ago

pinging this to prevent it from going stale. It does not appear this has been merged yet - is there anything additional required from me?

techfort commented 5 years ago

oops, done @josh-sachs-epic released as 1.5.8

josh-sachs-epic commented 5 years ago

Thanks! Will this eventually get pushed to npm?

techfort commented 5 years ago

@josh-sachs-epic - 1.5.8 published