Fix _getChunk when chunk is empty but next one is not

techfort / LokiJS

javascript embeddable / in-memory database

http:/techfort.github.io/LokiJS

MIT License

6.75k stars 481 forks source link

Fix _getChunk when chunk is empty but next one is not #821

Closed radex closed 4 years ago

radex commented 4 years ago

Found an ugly (and stupid on my part) bug in production. Thankfully my sanity checks caught it, making diagnosis easier and avoiding data inconsistency :)

radex commented 4 years ago

Funny enough, my initial commit introduced a much more serious bug… and then during the attempt to write a regression test, I found another bug, and fixed that one too ;)

gabzim commented 4 years ago

is this going to get merged at some point?

radex commented 4 years ago

yes, please merge! This fixes an important bug in IncrementalIndexedDB adapter

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

radex commented 4 years ago

bad bot

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

radex commented 4 years ago

please stop, bot